replaced icafe with metadata extractor #2546
Conversation
| @@ -90,7 +90,8 @@ dependencies { | |||
| //swipe_layout | |||
| implementation 'com.daimajia.swipelayout:library:1.2.0@aar' | |||
| implementation 'com.nineoldandroids:library:2.4.0' | |||
| implementation files('libs/icafe-1.1-SNAPSHOT.jar') | |||
| //metadata extractor | |||
| implementation 'com.drewnoakes:metadata-extractor:2.11.0' | |||
There was a problem hiding this comment.
this dependency already exists. :)
There was a problem hiding this comment.
I am sorry I'll remove it
| @@ -20,7 +23,10 @@ | |||
|
|
|||
| /** | |||
| * Methods for pre-processing images to be uploaded | |||
| */ | |||
| *//*if (dataInBytes[0] == 70 && dataInBytes[1] == 66 && dataInBytes[2] == 77 && dataInBytes[3] == 68) { | |||
There was a problem hiding this comment.
is this comment intentional?
There was a problem hiding this comment.
It was added mistakenly I'll remove it
| @@ -428,6 +431,34 @@ public String getFileName() { | |||
| public Place getPlace() { | |||
| return place; | |||
| } | |||
|
|
|||
| public Uri getContentUri() { | |||
There was a problem hiding this comment.
This is not required. Instead of generating content uri here, simply pass it to UploadItem from UploadableFile.
…/apps-android-commons into vanshikaarora-metadata_extractor
Content uri
|
@maskaravivek I have updated the PR. Kindly review :) |
Codecov Report
@@ Coverage Diff @@
## master #2546 +/- ##
=========================================
+ Coverage 5.89% 5.91% +0.02%
=========================================
Files 258 258
Lines 12310 12319 +9
Branches 1110 1113 +3
=========================================
+ Hits 726 729 +3
- Misses 11525 11531 +6
Partials 59 59
Continue to review full report at Codecov.
|
|
Thanks for approving the PR @maskaravivek :) |
Removed the icafe library and shifted to metadata extractor
Fixes #2518 Migrate from Icafe to metadata-extractor
Changes made